Wire up Zarr property tests EAR-1189 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
changed the title
dcherian
changed the title
EAR-1296 setting metadata can fail
import icechunk
from zarr.core.buffer.cpu import Buffer
props = b'{\n "shape": [\n 1\n ],\n "fill_value": false,\n "chunk_grid": {\n "name": "regular",\n "configuration": {\n "chunk_shape": [\n 1\n ]\n }\n },\n "attributes": {},\n "zarr_format": 3,\n "data_type": "bool",\n "chunk_key_encoding": {\n "name": "default",\n "configuration": {\n "separator": "/"\n }\n },\n "codecs": [\n {\n "name": "bytes",\n "configuration": {\n "endian": "little"\n }\n }\n ],\n "node_type": "array"\n}'
store = await icechunk.IcechunkStore.from_json(
config={"storage": {"type": "in_memory"}, "dataset": {}}, mode="w"
)
await store.set("/0/zarr.json", Buffer.from_bytes(props)) |
dcherian
force-pushed
the
zarr-prop-tests
branch
from
dd1c53e to
d18223d
Compare
dcherian
changed the title
* main: (167 commits) Bump actions/checkout from 2 to 4 in the actions group (#305) update zarr pin to v3.0.0b1 (#302) Fix non-conformant "attributes" metadata (#303) Implement branch reset functionality (#301) README minor tune up: syntax and other very minor typos etc (#300) remove awaits in icechunk notebook (#298) Add missing permission to release action (#295) Minor changes to virtual docs (#293) Add changelogs (#291) Install cargo release (#290) Update python ci (#289) GHA workflow to release Rust (#288) Release 0.1.0-alpha.3 to the Rust world (#287) `ByteRange` can do last n bytes now (#285) Introduce `Store::list_dir_items` (#286) [Docs] Improve virtual ref docs (#284) [Docs] correct output dimensions in xr example (#283) [Docs] add note for requirements of tutorial data download (#282) [Docs] correct module calls to match imports (#281) fix(docs): Docs postlaunch fixes (#278) ...
* main: Linting with ruff (#394)
dcherian
commented
Nov 15, 2024
mpiannucci
approved these changes
Nov 15, 2024
mpiannucci
reviewed
Nov 15, 2024
| import hypothesis.strategies as st | ||
| from hypothesis import assume, given, settings | ||
|
|
||
| from zarr.testing.strategies import arrays, numpy_arrays |
There was a problem hiding this comment.
This is awesome... we should embrace this for the other tests as well in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened up issues for following up:
fill_valuewith NaNs and Infs #391