Bump to Zarr3b3 #454
Merged
Bump to Zarr3b3 #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paraseba
approved these changes
Dec 6, 2024
dcherian
commented
Dec 6, 2024
| @@ -122,8 +122,8 @@ def test_array_name_properties_no_group( | |||
| store=store, shape=(100,), chunks=(10,), zarr_format=zarr_format, dtype="i4" | |||
| ) | |||
| assert arr.path == "" | |||
| assert arr.name is None | |||
| assert arr.basename is None | |||
There was a problem hiding this comment.
We should delete some of these tests, they don't really exercise icechunk and duplicate the Zarr property tests.
EDIT: I confirmed that this change matches the upstream change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.