Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add Virtual Ref Documentation and tutorial #240

Merged
merged 15 commits into from
Oct 15, 2024
Merged

Conversation

mpiannucci
Copy link
Contributor

@mpiannucci mpiannucci commented Oct 15, 2024

closes #214

Copy link
Contributor

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I just have a bunch of minor comments.

While virtual references are fully supported in Icechunk, creating virtual datasets relies on using experimental or pre-release versions of open source tools. For full instructions on how to install the required tools and ther current statuses [see the tracking issue on Github](https://github.com/earth-mover/icechunk/issues/197).

To create virtual Icechunk datasets with python, we utilize the [kerchunk](https://fsspec.github.io/kerchunk/) and [VirtualiZarr](https://virtualizarr.readthedocs.io/en/latest/) packages. `kerchunk` allows us to extract virtual references from existing data files, and `VirtualiZarr` allows us to use `xarray` to combine these extracted virtual references into full blown datasets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst it's true that kerchunk is (currently) being used under the hood by virtualizarr.open_virtual_dataset, it might just be confusing to mention kerchunk here. It doesn't appear at all in user code in this tutorial, so it's basically an implementation detail. Kerchunk is still mentioned in the icechunk FAQ as an inspiration, as well as in the virtualizarr docs.

docs/docs/icechunk-python/virtual.md Outdated Show resolved Hide resolved
docs/docs/icechunk-python/virtual.md Outdated Show resolved Hide resolved
docs/docs/icechunk-python/virtual.md Show resolved Hide resolved
docs/docs/icechunk-python/virtual.md Outdated Show resolved Hide resolved
docs/docs/icechunk-python/virtual.md Outdated Show resolved Hide resolved
docs/docs/icechunk-python/virtual.md Outdated Show resolved Hide resolved
docs/docs/icechunk-python/virtual.md Outdated Show resolved Hide resolved
docs/docs/icechunk-python/virtual.md Outdated Show resolved Hide resolved
docs/docs/icechunk-python/virtual.md Show resolved Hide resolved
@mpiannucci
Copy link
Contributor Author

great feedback thanks!!!

Copy link
Contributor

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

A few minor wording changes, then please merge.

docs/docs/icechunk-python/virtual.md Outdated Show resolved Hide resolved
docs/docs/icechunk-python/virtual.md Outdated Show resolved Hide resolved
docs/docs/icechunk-python/virtual.md Outdated Show resolved Hide resolved
docs/docs/icechunk-python/virtual.md Outdated Show resolved Hide resolved
@mpiannucci mpiannucci merged commit a7bcf44 into main Oct 15, 2024
@mpiannucci mpiannucci deleted the matt/virtual-docs branch October 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Virtual datasets
3 participants