Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sethet computation in perform_atmospheric_chemistry_and_microphys… #375

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

odiazib
Copy link
Contributor

@odiazib odiazib commented Nov 15, 2024

No description provided.

…ics.

Add function (mmr2vmr_col) to compute VMR for an entire column.

Switch to ConstColumnView for ATM variables.

Create a sethet function with work arrays and a smaller number of inputs.

Rename sethet to sethet_detail.

Use View2D for het_rates to avoid copying data.
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.88%. Comparing base (e26b5b6) to head (d88795b).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/mam4xx/mo_sethet.hpp 94.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          45       45           
  Lines        9339     9340    +1     
=======================================
+ Hits         8955     8956    +1     
  Misses        384      384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@singhbalwinder singhbalwinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@odiazib odiazib merged commit 7d7a4a6 into main Nov 18, 2024
8 checks passed
@odiazib odiazib deleted the oscar/sethet_interface branch November 18, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants