Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed phtcnt from a Real to an int. #262

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

jeff-cohere
Copy link
Collaborator

This change lets us use phtcnt to size arrays on the GPU.

Copy link
Contributor

@odiazib odiazib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this bug.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b377a2d) 96.05% compared to head (5fae6b0) 96.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files          34       34           
  Lines        6844     6844           
=======================================
  Hits         6574     6574           
  Misses        270      270           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeff-cohere jeff-cohere merged commit af6bbcd into main Nov 21, 2023
8 checks passed
@jeff-cohere jeff-cohere deleted the jeff-cohere/phtcnt-type-fix branch November 21, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants