Add wetdep compute_tendencies test. #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 96.40% 96.58% +0.17%
==========================================
Files 30 30
Lines 6036 6295 +259
==========================================
+ Hits 5819 6080 +261
+ Misses 217 215 -2
|
jeff-cohere
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Looks good to me. Thanks!
Not-very-related question: Is #175 still an issue that we need to address?
|
Yes, I would say that #175 is still an issue. It is more of a question than an issue: "Should evapc be used in the lprec calculation?" Until someone comes up with a definitive answer, I guess it stays open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.