Water uptake final. #222
Merged
Water uptake final. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 96.59% 96.09% -0.50%
==========================================
Files 32 32
Lines 6394 6523 +129
==========================================
+ Hits 6176 6268 +92
- Misses 218 255 +37
☔ View full report in Codecov by Sentry. |
odiazib
approved these changes
Sep 27, 2023
| } | ||
|
|
||
| KOKKOS_INLINE_FUNCTION | ||
| void modal_aero_water_uptake_dr( |
There was a problem hiding this comment.
Does this function corresponds to the subroutine modal_aero_wateruptake_dr from here.
There was a problem hiding this comment.
It does. I've added comments to make this clear.
jeff-cohere
reviewed
Sep 27, 2023
jeff-cohere
reviewed
Sep 27, 2023
jeff-cohere
reviewed
Sep 27, 2023
jeff-cohere
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last PR for water uptake! This PR brings a port of
modal_aero_water_uptake_dr, which is a top level driver.