Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EbaySvg: allow to include/exclude certain icons #42

Closed
pcanella opened this issue Jul 18, 2022 · 0 comments · Fixed by #371
Closed

EbaySvg: allow to include/exclude certain icons #42

pcanella opened this issue Jul 18, 2022 · 0 comments · Fixed by #371
Labels
enhancement New feature or request tech debt The update/fix/change is overdue

Comments

@pcanella
Copy link
Member

We need to provide some props for including only required icons in the resulting SVG. Another way is to include all icons (like it works now) but exclude some that are not needed.

Example:

type Props = {
  include?: Icon[];
  exclude?: Icon[];
}
<EbaySvg include={['calendar', 'chevronUp', 'chevronDown']} />
<EbaySvg exclude={['calendar', 'chevronUp', 'chevronDown']} />

Small nuance:
EbaySvg component is generated by scripts/update-icons.js

@pcanella pcanella added enhancement New feature or request tech debt The update/fix/change is overdue labels Jul 18, 2022
@darkwebdev darkwebdev linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tech debt The update/fix/change is overdue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant