Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Icon Displayed in EbayProgressStepper for Active Step #253

Closed
lbn21 opened this issue Oct 4, 2023 · 1 comment
Closed

Incorrect Icon Displayed in EbayProgressStepper for Active Step #253

lbn21 opened this issue Oct 4, 2023 · 1 comment

Comments

@lbn21
Copy link

lbn21 commented Oct 4, 2023

I have been utilising the EbayProgressStepper component and noticed that the icon representing the current active step doesn't seem to be the expected one. I am unsure if there were recent changes to this component that may have led to this inconsistency.

Upon further inspection, I found that the active state is utilising stepperConfirmation24 instead of what I anticipated to be stepperCurrent24. Here is a snippet of the code:

const typeIcons: { [key in StepState]: Icon } = {
    complete: 'stepperConfirmation24',
    attention: 'stepperAttention24',
    upcoming: 'stepperUpcoming24',
    active: 'stepperConfirmation24'
}

Would someone be able to confirm if this is the intended behaviour or if there's a recent update that altered this mapping? Thank you!

@darkwebdev
Copy link
Collaborator

Hey man! Progress stepper doesn't use current step icon anymore. It was changed in Skin: https://opensource.ebay.com/skin/#progress-stepper
Also Marko version behaves the same way: https://opensource.ebay.com/ebayui-core/?path=/story/progress-ebay-progress-stepper--in-progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants