Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent default preselection in Listbox component #247

Closed
renka opened this issue Sep 15, 2023 · 2 comments
Closed

Prevent default preselection in Listbox component #247

renka opened this issue Sep 15, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@renka
Copy link
Contributor

renka commented Sep 15, 2023 •
edited by darkwebdev
Loading

The requirement is that, on page load, the dropdown should display only a placeholder without any preselected value. Once the user selects an option, they should not be able to deselect it.
The similar behavior is in Marko:
https://opensource.ebay.com/ebayui-core/?path=/story/buttons-ebay-listbox-button--standard
@renka
Copy link
Contributor Author

renka commented Sep 21, 2023

#248

@renka renka mentioned this issue Sep 21, 2023
Merged
@darkwebdev
Copy link
Collaborator

wow, looks like it's a bug:
https://opensource.ebay.com/ebayui-core-react/main/?path=/story/ebay-listbox-button--default-no-selected-option

thanks for reporting!

@darkwebdev darkwebdev added the bug Something isn't working label Oct 6, 2023
darkwebdev added a commit that referenced this issue Oct 12, 2023
@renka @isaturina @darkwebdev
[#247] FIX: Do not preselect any option in Listbox with floating label (
428efc6 
#248)

* Do not preselect an option

* update test

---------

Co-authored-by: isaturina <[email protected]>
Co-authored-by: Timur Manyanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darkwebdev @renka