Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix src/tracer.hxx stack-buffer-overflow when using vsnprintf's return value (#502) #503

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

byronhe
Copy link
Contributor

@byronhe byronhe commented Apr 22, 2024

No description provided.

Copy link
Contributor

@greensky00 greensky00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. A couple of minor comments.

tests/CMakeLists.txt Show resolved Hide resolved
tests/unit/logger_test.cxx Outdated Show resolved Hide resolved
@byronhe
Copy link
Contributor Author

byronhe commented Apr 24, 2024

Thanks, looks good to me. A couple of minor comments.

Thank you for your suggestion. I made fix according to your advice. Could you please review it again?

Copy link
Contributor

@greensky00 greensky00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@greensky00 greensky00 merged commit 17cdd1f into eBay:master Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants