Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update is_proposer definition #600

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update is_proposer definition #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class HomestoreConan(ConanFile):
name = "homestore"
version = "6.6.3"
version = "6.6.4"

homepage = "https://github.com/eBay/Homestore"
description = "HomeStore Storage Engine"
Expand Down
2 changes: 1 addition & 1 deletion src/lib/replication/repl_dev/raft_repl_dev.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ repl_req_ptr_t RaftReplDev::applier_create_req(repl_key const& rkey, journal_typ
}

// rreq->init will allocate the block if it has linked data.
auto status = rreq->init(rkey, code, false /* is_proposer */, user_header, key, data_size, m_listener);
auto status = rreq->init(rkey, code, m_raft_server_id == rkey.server_id, user_header, key, data_size, m_listener);
if (!rreq->has_linked_data()) { return rreq; }
#ifdef _PRERELEASE
if (is_data_channel) {
Expand Down
12 changes: 3 additions & 9 deletions src/lib/replication/repl_dev/raft_state_machine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,9 @@ repl_req_ptr_t RaftStateMachine::localize_journal_entry_finish(nuraft::log_entry

auto rreq = m_rd.repl_key_to_req(rkey);
if ((rreq == nullptr) || (rreq->is_localize_pending())) {
rreq = localize_journal_entry_prepare(lentry);
if (rreq == nullptr) {
RELEASE_ASSERT(rreq != nullptr,
"We get an linked data for rkey=[{}], jentry=[{}] not as part of Raft Append but "
"indirectly through possibly unpack() and in those cases, if we are not able to alloc "
"location to write the data, there is no recourse. So we must crash this system ",
rkey.to_string(), jentry->to_string());
return nullptr;
}
// This path is for log pack apply only.
// Now we fully disabled log pack/unpack with the new_learner opt, should not reaching here.
RELEASE_ASSERT(false, "rreq should have already localized for rkey=[{}]", rkey.to_string());
}

if (rreq->is_proposer()) {
Expand Down
Loading