Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml2js 0.2 defaults have changed #26

Open
timretout opened this issue Aug 23, 2014 · 0 comments
Open

xml2js 0.2 defaults have changed #26

timretout opened this issue Aug 23, 2014 · 0 comments

Comments

@timretout
Copy link

As part of packaging webfinger for Debian, I noticed the test suite fails with xml2js 0.2.8. This patch fixes it:

Index: node-webfinger/lib/webfinger.js
===================================================================
--- node-webfinger.orig/lib/webfinger.js
+++ node-webfinger/lib/webfinger.js
@@ -95,7 +95,7 @@ var xrd2jrd = function(str, callback) {
     };
     Step(
         function() {
-            var parser = new xml2js.Parser();
+            var parser = new xml2js.Parser(xml2js.defaults["0.1"]);
             parser.parseString(str, this);
         },
         function(err, doc) {

Obviously the "real" fix would be to look into what has actually changed between 0.1 and 0.2, but I have not explored that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant