Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend test contact-modal-opens flaky #1848

Closed
richardebeling opened this issue Jan 8, 2023 · 3 comments · Fixed by #1881
Closed

Frontend test contact-modal-opens flaky #1848

richardebeling opened this issue Jan 8, 2023 · 3 comments · Fixed by #1881
Labels
[C] Tests and CI New or better testing and CI Discussion This issue requires some discussion and a decision what a solution might look like.

Comments

@richardebeling
Copy link
Member

In #1809, I attempted to add a frontend test to make sure the issue doesn't reappear. Despite best efforts to write the test in such a way that CSS animations do not interfere with the test logic, the test still regularly fails in CI.

I don't know what to do about it apart from disabling/removing the test.

@richardebeling richardebeling added the [C] Tests and CI New or better testing and CI label Jan 8, 2023
@janno42 janno42 added the Discussion This issue requires some discussion and a decision what a solution might look like. label Jan 16, 2023
@niklasmohrin
Copy link
Member

So there is https://docs.djangoproject.com/en/4.1/topics/testing/tools/#liveservertestcase which seems like what we want - they even provide an example that uses Selenium.

@richardebeling
Copy link
Member Author

So there is https://docs.djangoproject.com/en/4.1/topics/testing/tools/#liveservertestcase which seems like what we want - they even provide an example that uses Selenium.

Oh, sorry, I wasn't focussed when we talked about this earlier: I think this is a different issue. The flaky test here is about us being unable to write test-assert-logic for what we want to assert with selenium. This would also be the case if we were driving selenium out of a python test case. The live server test case is about having a backend available during frontend tests, so we can observe database side effects of interactions with the UI.

For this issue, I think we should just remove the test if we can't find a way to make it work properly.
For the live server test case, I think this belongs to another issue, I think we should make a new one for that?

@niklasmohrin
Copy link
Member

See #1854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Tests and CI New or better testing and CI Discussion This issue requires some discussion and a decision what a solution might look like.
Development

Successfully merging a pull request may close this issue.

3 participants