Feat: core updates (ng17) #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussion
There were quite a lot of visual regressions noticed following the update (particularly things like buttons in headers not displaying correctly). I've addressed all issues noticed, however there may still be minor issues discovered following future testing. Additionally the pdf viewer had incompatibilities and required various fixes/upgrades - I think all is working as expected but again would benefit from additional functional testing
New features available from update can be found at:
https://blog.angular.io/introducing-angular-v17-4d7033312e4b
Preview
Link to app preview if relevant
Screenshots / Videos
Include at least 1-2 screenshots of videos if visual changes