Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Custom card draw #230

Closed
Tracked by #51
chrismclarke opened this issue Feb 2, 2024 · 0 comments · Fixed by #270
Closed
Tracked by #51

Feat: Custom card draw #230

chrismclarke opened this issue Feb 2, 2024 · 0 comments · Fixed by #270
Assignees

Comments

@chrismclarke
Copy link
Collaborator

chrismclarke commented Feb 2, 2024

Is your feature request related to a problem? Please describe.
Previously we had a system where users could draw custom budget cards when a given activity or input is not available. This was removed due to technical incompatibility (3rd party package used wasn't maintained).

We would like to bring back the option for users to draw their own visual representations for cards that do not exist in the project. This feature would initially be used in the budget tool, but likely extended to be used across most other tools as well.

Describe the solution you'd like

  • Add perfect-freehand package
  • Create a standalone picsa-drawing component in libs\shared\src\features\drawing that provides a minimal ui for drawing
  • Integrate the component into apps\picsa-tools\budget-tool\src\app\components\card\card-new\card-new-dialog.html

Describe alternatives you've considered
After looking at a few options, I think the best drawing library suited to our needs would be perfect-freehand

The interface for this tool is nice and simple, and output looks more natural than tldraw or drawingboard.js

The most popular drawing library I could find is excalidraw. This has a lot more featuers (infinite whiteboard, text, image, shapes etc.), however it actually uses perfect-freehand to manage freestyle drawing anyway so if we later wanted more features it should be a reasonable migration process.

Additional context
Perfect freehand demo available at: https://www.perfectfreehand.com/

Getting a smooth workflow to work on a component that will only be used in a popup window is a bit tricky, you may find it easier to first work on the component first within a new page, e.g. /budget/card-editor

@chrismclarke chrismclarke changed the title Fix draw custom Feat: Custom card draw Feb 2, 2024
@chrismclarke chrismclarke moved this to Next Priority in PICSA Apps Development Feb 23, 2024
@chrismclarke chrismclarke moved this from Next Priority to In Progress in PICSA Apps Development Mar 11, 2024
@chrismclarke chrismclarke moved this from In Progress to Next Priority in PICSA Apps Development Mar 11, 2024
@chrismclarke chrismclarke moved this from Next Priority to In Progress in PICSA Apps Development Mar 12, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in PICSA Apps Development Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants