Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Today" button in trip diary's date selector isn't working #432

Closed
asiripanich opened this issue Jul 13, 2019 · 3 comments
Closed

"Today" button in trip diary's date selector isn't working #432

asiripanich opened this issue Jul 13, 2019 · 3 comments

Comments

@asiripanich
Copy link
Member

asiripanich commented Jul 13, 2019

Not sure if this problem is exclusively to rk-unsw branch or not. Does it work on other branches?

@shankari
Copy link
Contributor

shankari commented Aug 6, 2019

This is a bug in the datepicker library that we use (rajeshwarpatlolla/ionic-datepicker#300). That issue describes a fix; let me see if applying that fixes it.

@shankari
Copy link
Contributor

shankari commented Aug 6, 2019

The fixes to the master branch of the datepicker library work, but there has been no release since Sept 2016, so the changes are not in any dist file. The same issue pointed to a fork that had supposedly fixed the issue and had a recent distfile, but on testing, it looked like it is not actually working for our use case rajeshwarpatlolla/ionic-datepicker#300 (comment)

So I am checking in a manually generated distfile for now while waiting for the others to respond on the issue in the library.

@shankari
Copy link
Contributor

shankari commented Aug 6, 2019

@asiripanich you need to merge this fix to your branch. You might also want to merge
e-mission/e-mission-phone#596
at the same time :)

@shankari shankari closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants