Filter by Tag name on data sources

[ironashram]

Hi,
i would like to extend the tags capability of the provider, specifically allowing the data sources to filter by tag name, in particular for our current use case it would be needed for devices and virtual_machines data sources, but i guess it can be applied even more widely.
Before getting down to it deeply i wanted to discuss a bit the eventual implementation as it may not be acceptable for you.

I have done some quick experiments, please note that the patches below are only an indication

• Option 1

https://github.com/e-breuninger/terraform-provider-netbox/compare/master...ironashram:terraform-provider-netbox:tags_experiment_1?expand=1

Which returns something like

                  + tags            = [
                      + {
                          + description = ""
                          + id          = 27
                          + name        = "ceph-mon"
                          + slug        = "ceph-mon"
                        },
                      + {
                          + description = ""
                          + id          = 24
                          + name        = "controlplane"
                          + slug        = "controlplane"
                        },
                      + {
                          + description = ""
                          + id          = 26
                          + name        = "etcd"
                          + slug        = "etcd"
                        },
                      + {
                          + description = ""
                          + id          = 23
                          + name        = "spare-blade"
                          + slug        = "spare-blade"
                        },

• Option 2

https://github.com/e-breuninger/terraform-provider-netbox/compare/master...ironashram:terraform-provider-netbox:tags_experiment_2?expand=1

Which returns something like

                  + tag_ids        = [
                      + 27,
                      + 24,
                      + 26,
                      + 23,
                    ]
                  + tag_names      = [
                      + "ceph-mon",
                      + "controlplane",
                      + "etcd",
                      + "spare-blade",
                    ]

In principle i really prefer the first option as it seems more consistent with the netbox api, but on the other hand implementing that on all resources would be a breaking change.

Let me know what is your vision on this

[kyle-burnett]

+1

I think the ability to filter existing resources by tag is much needed functionality within the provider.

To accomplish this currently, we need to use a lot of external data sources to query the Netbox API directly. Being able to do this with "real" terraform data resources would be awesome.

[fbreckle]

I agree that we should go with Option 1. This came back on my plate due to #321.