Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2277 Fix failure when StatisticsHandler returns NaN #2278

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

solonovamax
Copy link
Contributor

@solonovamax solonovamax commented Nov 11, 2024

Fixes #2277

Should we reset the StatisticsHandler when one of its fields is NaN?

TODO: add test case for all edge cases of StatisticsHandler return values (some things use Int, some use Long, and some use Double):

  • 0
  • Int.MAX_VALUE
  • Int.MIN_VALUE
  • Long.MAX_VALUE
  • Long.MIN_VALUE
  • Double.MAX_VALUE
  • Double.MIN_VALUE
  • Double.NaN
  • Double.POSITIVE_INFINITY
  • Double.NEGATIVE_INFINITY

@solonovamax
Copy link
Contributor Author

Should be ready for merge now.

@dzikoysk dzikoysk merged commit fb062e5 into dzikoysk:main Nov 27, 2024
3 checks passed
@dzikoysk
Copy link
Owner

Thanks! Let's see how this one behaves

@dzikoysk dzikoysk changed the title Fix Failure When StatisticsHandler Returns NaN GH-2277 Fix failure when StatisticsHandler returns NaN Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot fetch metrics when Jetty's StatisticsHandler returns NaN
2 participants