Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2251 Fix Jetty Metrics Recording #2258

Merged

Conversation

solonovamax
Copy link
Contributor

Hopefully this uncooks the jetty metrics

Also bumps the version for prometheus metrics.

@dzikoysk
Copy link
Owner

dzikoysk commented Nov 1, 2024

Hopefully

Did you try to run this? 😅

@dzikoysk dzikoysk changed the title Fix Jetty Metrics Recording GH-2251 Fix Jetty Metrics Recording Nov 1, 2024
@solonovamax
Copy link
Contributor Author

solonovamax commented Nov 1, 2024

Hopefully

Did you try to run this? 😅

you never know, some magic issue might pop up later

but yes, I did run it successfully, and it seemed fine to me

@solonovamax
Copy link
Contributor Author

solonovamax commented Nov 1, 2024

actually I think I did something dumb, is there an easy way to take an arbitrary string and normalize it as a url path?

eg.

//metrics/// -> /metrics?
I couldn't find any from a quick look earlier

I want to compare the path of the request against the path used for the metrics to see if it matches, and if so not record it for the responses count: https://github.com/dzikoysk/reposilite/pull/2258/files#diff-49ac5f4caf3b0e7b0c1e4df2e3663b0dc45ec222b035e024ff35fa695e6846f5R75

@dzikoysk
Copy link
Owner

dzikoysk commented Nov 1, 2024

You could try with our Location class I think, it's intended to clean up messed paths (in general)

I thought I tested it?? bruh.
@dzikoysk dzikoysk merged commit 4818213 into dzikoysk:main Nov 2, 2024
3 checks passed
@dzikoysk
Copy link
Owner

dzikoysk commented Nov 2, 2024

Thanks, let's see how it'll work :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants