Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eurostat - use pure functions #1073

Open
trymzet opened this issue Oct 1, 2024 · 0 comments
Open

Eurostat - use pure functions #1073

trymzet opened this issue Oct 1, 2024 · 0 comments
Labels
2.0 viadot 2.0 enhancement New feature or request

Comments

@trymzet
Copy link
Contributor

trymzet commented Oct 1, 2024

Currently, the Eurostat source confusingly stores call-level parameters (eg. dataset_code) as attributes of an instance. They should just be params of the to_df() method instead.

#1041 (comment)
@trymzet trymzet added enhancement New feature or request 2.0 viadot 2.0 labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0 viadot 2.0 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trymzet