Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils.filter_df_columns() should not modify input but return the filtered DataFrame #1046

Open
adrian-wojcik opened this issue Sep 23, 2024 · 0 comments
Open

utils.filter_df_columns() should not modify input but return the filtered DataFrame #1046

adrian-wojcik opened this issue Sep 23, 2024 · 0 comments
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0

Comments

@adrian-wojcik
Copy link
Contributor

Coments from @trymzet:

This function doesn't exist, but if it did, it shouldn't modify input but return a new df:

Suggested change:

        df_filtered = filter_df_columns(data_frame=data_frame, columns=self.columns)

Suggested change:

    return df_filtered
@adrian-wojcik adrian-wojcik added the 2.0 backlog Backlog for logic issues in connectors after migration label Sep 23, 2024
@adrian-wojcik adrian-wojcik mentioned this issue Sep 23, 2024
Merged
5 tasks
@trymzet trymzet changed the title filter_df_columns logic in Eurostat Source Refactor filter_df_columns() to not modify input and return the filtered DataFrame Sep 27, 2024
@trymzet trymzet changed the title Refactor filter_df_columns() to not modify input and return the filtered DataFrame Refactor utils.filter_df_columns() to not modify input and return the filtered DataFrame Sep 27, 2024
@trymzet trymzet changed the title Refactor utils.filter_df_columns() to not modify input and return the filtered DataFrame utils.filter_df_columns() should not modify input but return the filtered DataFrame Sep 27, 2024
@trymzet trymzet added the 2.0 viadot 2.0 label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0 backlog Backlog for logic issues in connectors after migration 2.0 viadot 2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trymzet @adrian-wojcik