From 800b628846070bed6e818dc88f1e26891a63c581 Mon Sep 17 00:00:00 2001
From: marcinpurtak <mpurtak@gmail.com>
Date: Wed, 6 Dec 2023 14:43:45 +0100
Subject: [PATCH] Updated tests, removed not necessary imports, changed file
 path parameter

---
 .../flows/test_sharepoint_to_adls.py          | 19 +++++++++++++++----
 viadot/flows/sharepoint_to_adls.py            |  4 ++--
 viadot/task_utils.py                          |  2 ++
 3 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/tests/integration/flows/test_sharepoint_to_adls.py b/tests/integration/flows/test_sharepoint_to_adls.py
index bf7b1e5e5..93a31f5d1 100644
--- a/tests/integration/flows/test_sharepoint_to_adls.py
+++ b/tests/integration/flows/test_sharepoint_to_adls.py
@@ -171,6 +171,11 @@ def test_sharepoint_list_to_adls_run_flow_overwrite_true(mocked_class):
 )
 @pytest.mark.run
 def test_sharepoint_list_to_adls_run_flow_fail_on_no_data_returned(mocked_class):
+    """
+    Test will check if flow is failing when empty DF is passed
+    with the given parameter if_no_data_returned = "fail"
+    CSV file should not be generated!
+    """
     flow = SharepointListToADLS(
         "test_sharepoint_to_adls_run_flow",
         output_file_extension=".csv",
@@ -183,8 +188,6 @@ def test_sharepoint_list_to_adls_run_flow_fail_on_no_data_returned(mocked_class)
     )
     result = flow.run()
     assert result.is_failed()
-    os.remove(ADLS_FILE_NAME_LIST + ".csv")
-    os.remove("test_sharepoint_to_adls_run_flow.json")
 
 
 @mock.patch(
@@ -193,6 +196,11 @@ def test_sharepoint_list_to_adls_run_flow_fail_on_no_data_returned(mocked_class)
 )
 @pytest.mark.run
 def test_sharepoint_list_to_adls_run_flow_success_on_no_data_returned(mocked_class):
+    """
+    Test will check if flow will succeed when empty DF is passed
+    with the given parameter if_no_data_returned = "skip"
+    Empty csv should be generated!
+    """
     flow = SharepointListToADLS(
         "test_sharepoint_to_adls_run_flow",
         output_file_extension=".csv",
@@ -217,6 +225,11 @@ def test_sharepoint_list_to_adls_run_flow_success_on_no_data_returned(mocked_cla
 def test_sharepoint_list_to_adls_run_flow_success_warn_on_no_data_returned(
     mocked_class,
 ):
+    """
+    Test will check if flow is failing when empty DF is passed
+    with the given parameter if_no_data_returned = "warn"
+    CSV file should not be generated!
+    """
     # Get prefect client instance
     flow = SharepointListToADLS(
         "test_sharepoint_to_adls_run_flow",
@@ -230,5 +243,3 @@ def test_sharepoint_list_to_adls_run_flow_success_warn_on_no_data_returned(
     )
     result = flow.run()
     assert result.is_successful()
-    os.remove(ADLS_FILE_NAME_LIST + ".csv")
-    os.remove("test_sharepoint_to_adls_run_flow.json")
diff --git a/viadot/flows/sharepoint_to_adls.py b/viadot/flows/sharepoint_to_adls.py
index edac65238..e9dfe4b72 100644
--- a/viadot/flows/sharepoint_to_adls.py
+++ b/viadot/flows/sharepoint_to_adls.py
@@ -224,7 +224,7 @@ def __init__(
             name (str): Prefect flow name.
             list_title (str): Title of Sharepoint List.
             site_url (str): URL to set of Sharepoint Lists.
-            file_name (str): Name of file in ADLS. Defaults to None.
+            file_name (str): Name of file(without extension) in ADLS . Defaults to None.
             adls_dir_path (str): Azure Data Lake destination folder/catalog path. Defaults to None.
             filters (dict, optional): Dictionary with operators which filters the SharepointList output. Defaults to None.
                         allowed dtypes: ('datetime','date','bool','int', 'float', 'complex', 'str')
@@ -371,7 +371,7 @@ def gen_flow(self) -> Flow:
 
             file_to_adls_task = AzureDataLakeUpload()
             file_to_adls_task.bind(
-                from_path=self.path,
+                from_path=self.local_file_path,
                 to_path=self.adls_dir_path,
                 overwrite=self.overwrite,
                 sp_credentials_secret=self.adls_sp_credentials_secret,
diff --git a/viadot/task_utils.py b/viadot/task_utils.py
index c87387efb..8f1f7fef5 100644
--- a/viadot/task_utils.py
+++ b/viadot/task_utils.py
@@ -28,6 +28,8 @@
 from viadot.config import local_config
 from viadot.exceptions import CredentialError, ValidationError
 from viadot.tasks import AzureDataLakeUpload, AzureKeyVaultSecret
+from viadot.task_utils import get_task_logs, search_for_msg_in_logs
+
 
 logger = logging.get_logger()
 METADATA_COLUMNS = {"_viadot_downloaded_at_utc": "DATETIME"}