From 0952b3d2dd4d70596573d70af1612ccb0470dff1 Mon Sep 17 00:00:00 2001 From: m-paz Date: Tue, 30 Nov 2021 18:14:28 +0100 Subject: [PATCH 1/5] =?UTF-8?q?=F0=9F=93=9D=20Bumped=20version=20after=20r?= =?UTF-8?q?elease?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- tests/test_viadot.py | 2 +- viadot/__init__.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_viadot.py b/tests/test_viadot.py index 4f6d057c2..247dce47d 100644 --- a/tests/test_viadot.py +++ b/tests/test_viadot.py @@ -2,4 +2,4 @@ def test_version(): - assert __version__ == "0.2.13" + assert __version__ == "0.2.14" diff --git a/viadot/__init__.py b/viadot/__init__.py index 11ef09286..f3291e93b 100644 --- a/viadot/__init__.py +++ b/viadot/__init__.py @@ -1 +1 @@ -__version__ = "0.2.13" +__version__ = "0.2.14" From af6943d9ff3eb51ef3d5bf4e5a5f39f0a52e23fa Mon Sep 17 00:00:00 2001 From: m-paz Date: Wed, 1 Dec 2021 11:06:20 +0100 Subject: [PATCH 2/5] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20authorization=20issu?= =?UTF-8?q?e?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- viadot/sources/cloud_for_customers.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/viadot/sources/cloud_for_customers.py b/viadot/sources/cloud_for_customers.py index 06984ac01..74a3cdc0d 100644 --- a/viadot/sources/cloud_for_customers.py +++ b/viadot/sources/cloud_for_customers.py @@ -52,9 +52,8 @@ def __init__( self.query_endpoint = endpoint self.params = params or {} self.params["$format"] = "json" - - if self.credentials: - self.auth = (self.credentials["username"], self.credentials["password"]) + if credentials: + self.auth = (credentials["username"], credentials["password"]) else: self.auth = (None, None) @@ -154,6 +153,7 @@ def get_response(self, url: str, params: Dict[str, Any] = None): session.mount("http://", adapter) session.mount("https://", adapter) + print(self.auth) response = session.get(url, params=params, auth=self.auth) response.raise_for_status() # TODO: abstract below and put as handle_api_response() into utils.py From c7004ac95e1f59272d07532eb17eb23afc7ad2e4 Mon Sep 17 00:00:00 2001 From: m-paz Date: Wed, 1 Dec 2021 11:07:20 +0100 Subject: [PATCH 3/5] =?UTF-8?q?=F0=9F=93=9D=20Updated=20changelog?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f8b92af10..3c8eedd6a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [0.2.14] +### Fixed +- authorization issue `CloudForCustomers` source + ## [0.2.13] ### Added - Added support for file path to `CloudForCustomersReportToADLS` flow From 12e72d360e1a92ec6af7e080f16482ddc7706e10 Mon Sep 17 00:00:00 2001 From: m-paz Date: Wed, 1 Dec 2021 11:17:38 +0100 Subject: [PATCH 4/5] =?UTF-8?q?=F0=9F=8E=A8=20Cleaned=20up=20code?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- viadot/sources/cloud_for_customers.py | 1 - 1 file changed, 1 deletion(-) diff --git a/viadot/sources/cloud_for_customers.py b/viadot/sources/cloud_for_customers.py index 74a3cdc0d..b06cc0a7f 100644 --- a/viadot/sources/cloud_for_customers.py +++ b/viadot/sources/cloud_for_customers.py @@ -153,7 +153,6 @@ def get_response(self, url: str, params: Dict[str, Any] = None): session.mount("http://", adapter) session.mount("https://", adapter) - print(self.auth) response = session.get(url, params=params, auth=self.auth) response.raise_for_status() # TODO: abstract below and put as handle_api_response() into utils.py From 062225a8a8ad833684d9f03088b6cd8e9f92feb7 Mon Sep 17 00:00:00 2001 From: m-paz Date: Wed, 1 Dec 2021 11:29:42 +0100 Subject: [PATCH 5/5] =?UTF-8?q?=F0=9F=93=9D=20Updated=20changelog?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3c8eedd6a..eb9f81482 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [0.2.14] ### Fixed -- authorization issue `CloudForCustomers` source +- authorization issue within `CloudForCustomers` source ## [0.2.13] ### Added