Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SysOsalNvRead() has wrong response type #3

Open
joonas-fi opened this issue May 29, 2021 · 0 comments
Open

SysOsalNvRead() has wrong response type #3

joonas-fi opened this issue May 29, 2021 · 0 comments

Comments

@joonas-fi
Copy link

joonas-fi commented May 29, 2021 •
edited
Loading

znp-go/command.go

Line 208 in 69131cf

func (znp *Znp) SysOsalNvRead(id uint16, offset uint8) (rsp *StatusResponse, err error) {

I believe the correct response type is SysOsalNvReadResponse:

znp-go/model.go

Line 347 in 69131cf

type SysOsalNvReadResponse struct {

The incorrect one takes into account only the status, the correct one also includes the read NVRAM content

I tested and NVRAM reading works with this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joonas-fi