Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steward can miss asyncInbound frames #1

Open
joonas-fi opened this issue May 16, 2021 · 0 comments
Open

Steward can miss asyncInbound frames #1

joonas-fi opened this issue May 16, 2021 · 0 comments

Comments

@joonas-fi
Copy link

asyncInbound is an unbuffered channel, and this line is using non-blocking send:

case znp.asyncInbound <- cp:

This looked dangerous to me, so I added error logging to the default: case (failed to send), and sure enough, I was actually running into this. If consumer (let's say Steward) is processing an existing message and therefore is not waiting to receive, inbound frames are silently dropped on the floor.

Easy solution is to make this channel buffered, perhaps 10 or 100 frames.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant