Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Bug] CBS Ids truncated for 2024 Players #64

Open
jplata opened this issue Oct 29, 2024 · 4 comments
Open

[Data Bug] CBS Ids truncated for 2024 Players #64

jplata opened this issue Oct 29, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@jplata
Copy link

jplata commented Oct 29, 2024

Describe the data bug
It would appear cbs_id column for many (all?) new players for 2024 are missing the final digit.

Which file is having trouble?
db_playerids.csv

Expected data
Example:

  • Jonathon Brooks cbs_id in file: 2673070

  • Jonathon Brooks actual cbs_id: 26730706

  • Malik Nabers cbs_id in file: 2669776

  • Malik Nabers actual cbs_id: 26697761

@jplata jplata added the bug Something isn't working label Oct 29, 2024
@tanho63
Copy link
Member

tanho63 commented Oct 30, 2024

Hm, this is strange. I think we get these IDs from the MFL API. Do you have a list of all the ones that are wrong ?

@jplata
Copy link
Author

jplata commented Oct 31, 2024

I don't have a full list, I was pulling in 2024 Draft Data for a league, and noticed it was not matching on the 2024 rookies - so my assumption is any new players added in 2024 could be wrong.

@jplata
Copy link
Author

jplata commented Nov 18, 2024

Should we open a ticket w/ MFL to see if they can resolve the CBS player ids? Or any other known solutions?

@tanho63
Copy link
Member

tanho63 commented Nov 18, 2024

Yeah, it could be worth trying with MFL support, would you like to give that a go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants