Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsis_id 00-0029435 misattributed (Damari/Dennis Johnson) #42

Open
Adeiko opened this issue Oct 2, 2022 · 0 comments
Open

gsis_id 00-0029435 misattributed (Damari/Dennis Johnson) #42

Adeiko opened this issue Oct 2, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Adeiko
Copy link
Contributor

Adeiko commented Oct 2, 2022

In the FF player Ids, the 00-0029435 seems duplicated, and is missatributed.

load_ff_playerids() %>% filter(gsis_id == "00-0029435") %>% select(name,gsis_id)
name gsis_id

1 Dennis Johnson 00-0029435
2 Dennis Johnson 00-0029435

You can see here how it shows twice. But when you look for example at 2014 week 1 game for Houston, you can see how they atribute this to D.Johnson.

load_pbp(2014) %>% filter(game_id=="2014_01_WAS_HOU",play_id==83) %>% select(receiver,receiver_id)
receiver receiver_id

1 D.Johnson 00-0029435

Looking at PFR you can see how all teh targets where to Damaris Johnson, not Dennis
https://www.pro-football-reference.com/boxscores/201409070htx.htm
image

@Adeiko Adeiko added the bug Something isn't working label Oct 2, 2022
@tanho63 tanho63 changed the title Wrong Gsis ID gsis_id 00-0029435 misattributed (Damari/Dennis Johnson) Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant