Async items

[michalpokojski]

Super useful component :) Great work!

I've found one bug. It doesn't work with async items.

simple fix:

useEffect(() => {
  dispatch({ type: 'reset', initialState: props })
}, [props.items])

and everything works fine :)

I also tried on my side to trigger almost the same thing by using pagination.onResetPage() but useCallback from react memoize initial props so useEffect has come in handy 👍

[dylangarcia]

@michalpokojski so sorry I didn't see this! Glad you like it.

Can you provide a minimal repro for your issue? I think if I just add props to the dependency array of useCallback it should fix it!

[michalpokojski]

Actually, it's already there:

const onResetPage = useCallback(
    () => dispatch({ type: 'reset', initialState: props }),
    [props.items.length]
  )

but somehow it doesn't work, will try to reproduce it somewhere

@edit Something like this: https://codesandbox.io/s/vv5q4jx180

[drixie]

@dylangarcia This issue still exists.

Thanks for a very simple solution!

Also, is it possible to have a method that lists out page numbers in a specified format?