Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted code to Tensorflow 1 and changed skimage range #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

converted code to Tensorflow 1 and changed skimage range #27

wants to merge 1 commit into from

Conversation

martinosorb
Copy link

The code was converted using automatic conversion provided by Tensorflow.

Additionally, the most recent skimage was telling me its images needed to be between -1 and 1, the opposite of what your code and comments said. I changed that, adding a clip since some values were (very slightly) larger than 1.0. This is slightly suspicious...

Note: I also have a python 3 version, which is NOT included in this PR, but you may be interested in.

@dyelax
Copy link
Owner

dyelax commented Jul 19, 2018

Thanks for the PR! Honestly I haven't touched this repo in a while so I'll need to re-download the data, but I'll try to test this and merge this weekend

@dyelax
Copy link
Owner

dyelax commented Jul 19, 2018

Would also definitely be interested in your Python 3 version!

@martinosorb
Copy link
Author

Great, however if I push the py3, it may not be compatible with py2 anymore. Is that ok?

@dyelax
Copy link
Owner

dyelax commented Jul 21, 2018

What did you change to make it work with python3? I’d love to have it be cross-compatible if possible

@martinosorb
Copy link
Author

I used 2to3, which does it automatically, and then ran it to check it worked (I had to make one more change before it did). The 2to3 docs state it's usually not a good idea to try making code compatible with both 2 and 3, but that's up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants