chore: fix linux runner deps

dyazincahya-fork · Apr 25, 2023 · 13bafaa · 13bafaa
1 parent dca8bcd
commit 13bafaa
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/.github/workflows/spotube-release-binary.yml b/.github/workflows/spotube-release-binary.yml
@@ -99,7 +99,7 @@ jobs:
       - name: Install Dependencies
         run: |
           sudo apt-get update -y
-          sudo apt-get install -y tar clang cmake ninja-build pkg-config libgtk-3-dev make python3-pip python3-setuptools patchelf desktop-file-utils libgdk-pixbuf2.0-dev fakeroot strace fuse libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev libunwind-dev locate patchelf libsecret-1-0 libjsoncpp1 libsecret-1-dev libjsoncpp-dev
+          sudo apt-get install -y tar clang cmake ninja-build pkg-config libgtk-3-dev make python3-pip python3-setuptools patchelf desktop-file-utils libgdk-pixbuf2.0-dev fakeroot strace fuse libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev libunwind-dev locate patchelf libsecret-1-0 libjsoncpp25 libsecret-1-dev libjsoncpp-dev
 
       - name: Install AppImage Tool
         run: |

diff --git a/CONTRIBUTION.md b/CONTRIBUTION.md
@@ -120,9 +120,19 @@ Do the following:
 
 - Download the latest Flutter SDK (>=2.15.1) & enable desktop support
 - Install Development dependencies in linux
-  - `libsecret-1-0 libjsoncpp1 libsecret-1-dev libjsoncpp-dev libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev` (for Debian/Ubuntu)
-  - `libsecret jsoncpp gstreamer gst-libav gst-plugins-base gst-plugins-good` (for Arch/Manjaro)
-  - `libsecret libsecret-devel jsoncpp gstreamer1-devel gstreamer1-plugins-base-tools gstreamer1-doc gstreamer1-plugins-base-devel gstreamer1-plugins-good gstreamer1-plugins-good-extras` (for Fedora)
+  - Debian/Ubuntu
+    ```bash
+    $ apt-get install libjsoncpp1 libjsoncpp-dev libsecret-1-0 libsecret-1-dev libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
+    ```
+    - Use `libjsoncpp25` instead of `libjsoncpp1` (for Ubuntu >= 22.04)
+  - Arch/Manjaro
+    ```bash
+    yay -S libsecret jsoncpp gstreamer gst-libav gst-plugins-base gst-plugins-good
+    ```
+  - Fedora
+    ```bash
+    dnf install libsecret libsecret-devel jsoncpp gstreamer1-devel gstreamer1-plugins-base-tools gstreamer1-doc gstreamer1-plugins-base-devel gstreamer1-plugins-good gstreamer1-plugins-good-extras
+    ```
 - Clone the Repo & Run `flutter pub get` in the Terminal
 - Create a `secrets.json` in root of the project. The structure should be similar to the following example:
 

diff --git a/linux/packaging/deb/make_config.yaml b/linux/packaging/deb/make_config.yaml
@@ -13,7 +13,6 @@ dependencies:
   - libgstreamer1.0-dev
   - libgstreamer-plugins-base1.0-dev
   - libsecret-1-0
-  - libjsoncpp1
 
 essential: false
 icon: assets/spotube-logo.png