-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First opening the app shows issues only from August 2017 & before #260
Comments
Eep I think I fixed this before I stopped working on Tudo but didn't push. I think if you swap round lines 15 and 17 of the initial_rummage = IssueSorting.default_sort_by(initial_rummage)
{issues, rummage} =
IssueSorting.collect_issues(search_params, initial_rummage) vs the current: {issues, rummage} =
IssueSorting.collect_issues(search_params, initial_rummage)
rummage = IssueSorting.default_sort_by(rummage) |
Oh @Shouston3 made his own fix. Nevermind 😄 |
@finnhodgkin I think your solution is better, would you mind making a pr |
Sure thing 👍 |
@Shouston3 Might be good to complement @finnhodgkin's excellently simple PR with your test additions for this though 😊 |
My test was for my own helper function. |
@Shouston3 - this seems to be working on the heroku app but it's not working on my localhost, any suggestions why? |
Maybe you need to update your local database with the seed file. Something like |
@Shouston3 - I tried doing that before when I was following the instructions in the readme but I was getting this error: I looked into the error a little but couldn't work out what was going wrong. |
To fix this, you basically need to try and work through understanding what the |
As a user
I would like to come to the application and see the latest updated issues as a default
So that I get the most immediate needs shown to me first.
At the moment, the application shows only issues from August 2017 & before this date first:
And it is only on clicking 'Updated' twice that I get the updated list:
The text was updated successfully, but these errors were encountered: