Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Auth (AuthPlug) to MVP #65

Closed
8 tasks done
nelsonic opened this issue Sep 29, 2020 · 3 comments
Closed
8 tasks done

Add Auth (AuthPlug) to MVP #65

nelsonic opened this issue Sep 29, 2020 · 3 comments
Assignees
@nelsonic
Labels
enhancement New feature or enhancement of existing functionality priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Sep 29, 2020 •
edited
Loading

Now that we have Auth working https://dwylauth.herokuapp.com 🚀 we can add it to the MVP to simplify the App.

Todo

  • Add auth_plug to mix.exs see: https://github.com/dwyl/auth_plug
  • Enable auth_plug in router.ex
  • Enable AuthPlugOptional in router.ex for any routes where auth is optional
  • Remove all personally identifiable information from the MVP
    • Keep people table with bare minimum data to allow FK in items table to work.
  • Remove any auth related tests and let auth_plug handle all of that!
  • Ensure that everything still works as expected (tests for creating items should all still pass)
  • Get back to building the features we actually want! Proposed MVP feature list app#266
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality technical A technical issue that requires understanding of the code, infrastructure or dependencies T4h Time Estimate 4 Hours priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished labels Sep 29, 2020
@nelsonic nelsonic self-assigned this Sep 29, 2020
@nelsonic
Copy link
Member Author

nelsonic commented Sep 30, 2020 •
edited
Loading

Before: http://localhost:4000/
image

nelsonic added a commit that referenced this issue Sep 30, 2020
@nelsonic
update all dependencies to latest versions #65
ca461d7
nelsonic added a commit that referenced this issue Sep 30, 2020
@nelsonic
update config for Phoenix 1.5.5 ahead of #65
e806ff7
nelsonic added a commit that referenced this issue Sep 30, 2020
@nelsonic
remove ElixirAuthGoogle.generate_oauth_url/1 from page_controller as …
c3259ca 
…no longer used #65
nelsonic added a commit that referenced this issue Sep 30, 2020
@nelsonic
ripped out old auth code and added auth_plug. most tests fail (to be …
2d802dc 
…expected) ... fixing now. #65
nelsonic added a commit that referenced this issue Sep 30, 2020
@nelsonic
create test/app/person_test.exs to test basic Person CRUD #65
b5baf20
nelsonic added a commit that referenced this issue Sep 30, 2020
@nelsonic
create AppTest helper functions for #65
4a05c53
nelsonic added a commit that referenced this issue Sep 30, 2020
@nelsonic
update tests due to removal of auth #65
ff16a57
nelsonic added a commit that referenced this issue Sep 30, 2020
@nelsonic
delete or comment out unused code #65
a0a2078
@nelsonic
Copy link
Member Author

nelsonic commented Oct 1, 2020

Tests pass as does UI:
image

Need to decide what we're going to do with the home page:
image

I think it should immediately display the interface for inputting items.

@nelsonic
Copy link
Member Author

nelsonic commented Oct 1, 2020

Added auth_plug to MVP: #66

@nelsonic nelsonic closed this as completed Oct 1, 2020
nelsonic added a commit that referenced this issue Oct 2, 2020
@nelsonic
simplify people migration (retrospectively) to eliminate all PII #65
d6f90a4
nelsonic added a commit that referenced this issue Oct 2, 2020
@nelsonic
move items out of ctx #65
47ec5ec
nelsonic added a commit that referenced this issue Oct 2, 2020
@nelsonic
DELETE lib/app_web/templates/person/* #65
9495195
nelsonic added a commit that referenced this issue Oct 2, 2020
@nelsonic
Let's try that again ... #65
0c883ce
nelsonic added a commit that referenced this issue Oct 2, 2020
@nelsonic
simplify use of AuthPlugOptional in router.ex #65
28dc5a6
This was referenced Oct 2, 2020
Closed
Closed
iteles added a commit that referenced this issue Oct 4, 2020
@iteles
Merge pull request #66 from dwyl/use-auth_plug-issue-65
9d137bb 
PR: Use auth_plug to simplify auth in MPV App issue #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
enhancement New feature or enhancement of existing functionality priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic