Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elm-spa single page apps made easy #154

Open
nelsonic opened this issue Jan 11, 2020 · 2 comments
Open

elm-spa single page apps made easy #154

nelsonic opened this issue Jan 11, 2020 · 2 comments

Comments

@nelsonic
Copy link
Member

https://www.elm-spa.dev
https://discourse.elm-lang.org/t/elm-spa-single-page-apps-made-easy/4950

@SimonLab
Copy link
Member

image

@nelsonic
Copy link
Member Author

The elm-spa-example is a bit overwhelming from beginner's perspective ...
There is a lot of code in https://github.com/rtfeldman/elm-spa-example/tree/master/src spread over several files. This is good for "code organisation" but without any UI screenshots in the repo's README.md it's not clear where people should start reading the code.
Obviously we should start with Main.elm as the entry point, but then what? Read the files in alphabetical order?
The comments in the file are good when they exist but they are inconsistent. Some things are quite well explained an others are left for the reader to decipher/infer.

Finally my biggest gripe with the project, the /tests are limited to one file tests/RoutingTests.elm
which has a "TODO" comment:

-- TODO need to add lots more tests!

image
i.e. this "example" app was built following the "test later" methodology.
This is exactly what we want avoid beginners getting into the habit of doing! 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants