Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging without a review #470

Closed
rub1e opened this issue Oct 12, 2018 · 3 comments
Closed

Merging without a review #470

rub1e opened this issue Oct 12, 2018 · 3 comments
Assignees
@iteles
Labels
bug Suspected or confirmed bug (defect) in the code priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished question A question needs to be answered before progress can be made on this issue T25m Time Estimate 25 Minutes

Comments

@rub1e
Copy link
Member

rub1e commented Oct 12, 2018

I've just noticed that you can merge into master without having your PR reviewed in this repo - is that deliberate or an oversight?

Is there a set process for the permissions in dwyl repos?
@rub1e rub1e added bug Suspected or confirmed bug (defect) in the code question A question needs to be answered before progress can be made on this issue priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T25m Time Estimate 25 Minutes labels Oct 12, 2018
@nelsonic
Copy link
Member

https://github.com/dwyl/protect-master-branch

@nelsonic nelsonic assigned iteles and unassigned nelsonic Nov 21, 2018
@nelsonic
Copy link
Member

Assigned to Inês, because I am not the "owner" of this project.
If it were up to me the dwyl "site" would be a landing page for our product.

@iteles
Copy link
Member

iteles commented Nov 21, 2018

master branch now protected.
image

Now we have discussed that we will be moving back to product and we have a clear path to it (dwyl/technology-stack#67), we can start working on our product landing page again 🎉

@iteles iteles closed this as completed Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iteles iteles

Labels
bug Suspected or confirmed bug (defect) in the code priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished question A question needs to be answered before progress can be made on this issue T25m Time Estimate 25 Minutes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nelsonic @iteles @rub1e