Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tags from Auth App? #98

Open
3 tasks
nelsonic opened this issue Sep 5, 2020 · 1 comment
Open
3 tasks

Remove Tags from Auth App? #98

nelsonic opened this issue Sep 5, 2020 · 1 comment
Labels
chore a tedious but necessary task often paying technical debt discuss Share your constructive thoughts on how to make progress with this issue priority-3 Third priority. Considered "Nice to Have". Not urgent. question A question needs to be answered before progress can be made on this issue T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Sep 5, 2020

Context

We have two types of metadata that can be added to records in order to help categorise the data; tags and status.
Our reasoning for having these two types of metadata is simple: one is "system" and can only be applied by the application/admin, while the other is "user" and can be applied person using the app. This makes perfect sense in the
A record (e.g. person or app) can (only) have one status at a time e.g. verified or active respectively.
An item record can have multiple tags; I still think it makes perfect sense for items in the @dwyl App to use tags for categorisation, see: dwyl/app#245

The reason we have tags in the auth app is because we imported the schema from the app-mvp

Not Using tags

At present we are not using tags in the auth app.

dwylauth::DATABASE=> SELECT * FROM tags;

 id | text | inserted_at | updated_at | person_id
----+------+-------------+------------+-----------
(0 rows)

Correspondingly, none of the people records have a tag applied:

dwylauth::DATABASE=> select id, status, tag, inserted_at from people ORDER by id  DESC;

   id    | status | tag |     inserted_at
---------+--------+-----+---------------------
 9089056 |      1 |     | 2020-06-30 13:29:01
 6057298 |      1 |     | 2020-05-04 14:49:59
      13 |        |     | 2020-08-04 09:43:49
      12 |      1 |     | 2020-07-01 17:24:31
      11 |      1 |     | 2020-07-01 08:28:42
      10 |        |     | 2020-05-14 16:41:40
       9 |        |     | 2020-05-12 16:20:32
       8 |      1 |     | 2020-05-12 13:36:49
       7 |      1 |     | 2020-05-12 06:01:24
       6 |        |     | 2020-05-11 16:06:18
       5 |      1 |     | 2020-05-11 16:03:21
       3 |      1 |     | 2020-04-24 13:33:52
       2 |      1 |     | 2020-04-22 17:18:07
       1 |      1 |     | 2020-04-22 17:13:28
(14 rows)

Todo

@nelsonic nelsonic added question A question needs to be answered before progress can be made on this issue T1h Time Estimate 1 Hour chore a tedious but necessary task often paying technical debt discuss Share your constructive thoughts on how to make progress with this issue technical A technical issue that requires understanding of the code, infrastructure or dependencies labels Sep 5, 2020
@nelsonic
Copy link
Member Author

This is not urgent. But I think it's worth doing as a separate maintenance/cleanup PR at some point. ⏳

@nelsonic nelsonic added the priority-3 Third priority. Considered "Nice to Have". Not urgent. label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt discuss Share your constructive thoughts on how to make progress with this issue priority-3 Third priority. Considered "Nice to Have". Not urgent. question A question needs to be answered before progress can be made on this issue T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Development

No branches or pull requests

1 participant