Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically Create API Keys for a New App #97

Closed
2 tasks done
nelsonic opened this issue Sep 1, 2020 · 3 comments
Closed
2 tasks done

Automatically Create API Keys for a New App #97

nelsonic opened this issue Sep 1, 2020 · 3 comments
Assignees
@nelsonic
Labels
enhancement New feature or enhancement of existing functionality T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Sep 1, 2020 •
edited
Loading

At present we require manual creation of both the App and API Key. This feels like too many steps.
Provided the person has a verified account and admin role, they should be able to create an App with the bare minimum info and the act of creating an App should automatically create an API Key.

Todo

  • Automatically create an API Key when someone creates a new App
  • Display the API Key on the /apps/:id page so the person can see/use it immediately
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies labels Sep 1, 2020
@nelsonic
Copy link
Member Author

nelsonic commented Sep 1, 2020

At present this is the :show page for an App:
image

Going to update the get_app!/1 to fetch the associated apikeys and then display them on this page.

@nelsonic nelsonic self-assigned this Sep 1, 2020
@nelsonic nelsonic mentioned this issue Sep 1, 2020
Merged
13 tasks
nelsonic added a commit that referenced this issue Sep 7, 2020
@nelsonic
create apps before apikeys for #97
ecc6043
nelsonic added a commit that referenced this issue Sep 7, 2020
@nelsonic
fix 1/4 failing auth tests #97
a4d5e58
nelsonic added a commit that referenced this issue Sep 7, 2020
@nelsonic
update seeds and tests to create App before API Key #97
b7188d0
nelsonic added a commit that referenced this issue Sep 7, 2020
@nelsonic
fix failing tests for Apps #97
87c52d6
@nelsonic
Copy link
Member Author

nelsonic commented Sep 7, 2020

App Showing AUTH_API_KEY: http://localhost:4000/apps/1
image

@nelsonic
Copy link
Member Author

nelsonic commented Sep 8, 2020

New app creation automatically apikey for the app:
image

✅

Next: #99

@nelsonic nelsonic closed this as completed Sep 8, 2020
@nelsonic nelsonic mentioned this issue Sep 8, 2020
Closed
1 task
nelsonic added a commit that referenced this issue Sep 8, 2020
@nelsonic
[WiP:TestsFailing] automatically create API key when new app is inser…
5d52ed3 
…ted see: #97 (comment)
nelsonic added a commit that referenced this issue Sep 8, 2020
@nelsonic
rework create_app/1 to use case statement for errors #97
205c828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
enhancement New feature or enhancement of existing functionality T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic