Ensure that Roles (List) is Available on conn.assigns.person.roles

[nelsonic]

At present conn.assigns.person does not contain any roles:

%{
  aud: "Joken",
  auth_provider: "google",
  email: "[email protected]",
  exp: 1629492074,
  givenName: "Nelson",
  iat: 1597955074,
  id: 1,
  iss: "Joken",
  jti: "2omh7b4k1ck801ketc",
  nbf: 1597955074,
  picture: "https://lh3.googleusercontent.com/a-/AOh14GhaNpCI3Px",
  status: nil
}

• superuser (person.id==1) needs to have the superuser role assigned in seeds.exs.
• JWT (and thus conn.assigns.person) should have roles key and
  • it should contain a string of space-separated comma-separated role_ids
    e.g: "superadmin admin home_external" "1,8,42"

  Note: This helper function will be in RBAC: Transform List of Maps into Comma Separated String of Ints rbac#4

[th0mas]

Is there any reason to use a comma separated string over a list structure in the JWT/conn.assigns.person map?

[nelsonic]

@th0mas good question.
As you know, the JWT is returned in the URL following successful auth:

auth/lib/auth_web/controllers/auth_controller.ex

Lines 435 to 449 in fafc5e0

	def add_jwt_url_param(person, state, client_secret) do
	data = %{
	auth_provider: person.auth_provider,
	givenName: person.givenName,
	id: person.id,
	picture: person.picture,
	status: person.status,
	email: person.email
	}
	jwt = AuthPlug.Token.generate_jwt!(data, client_secret)
	List.first(String.split(URI.decode(state), "?")) <>
	"?jwt=" <> jwt
	end

Joken.generate_and_sign will stringify the data no matter what format it is in
so that it can be included in a URL.
All I'm doing is minimising the amount of data by transforming it to a String preemptively.

As for the conn.assigns.person map again, I'm just minimising the amount of data sent over the wire.

But as always open to suggestions. 💭

[nelsonic]

Sample:

conn.assigns.person: %{
  aud: "Joken",
  auth_provider: "google",
  email: "[email protected]",
  exp: 1629582005,
  givenName: "Nelson",
  iat: 1598045005,
  id: 1,
  iss: "Joken",
  jti: "2ommatp3m7qoguuoik000002",
  nbf: 1598045005,
  picture: "https://lh3.googleusercontent.com/a-/AOh14GhaNpCI3Px_VuIC8GkRuCY",
  roles: "1,8,42",
  status: 1
}

[nelsonic]

Included in #85