Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send "Verify your email address" Email #62

Closed
nelsonic opened this issue May 1, 2020 · 2 comments
Closed

Send "Verify your email address" Email #62

nelsonic opened this issue May 1, 2020 · 2 comments
Labels
enhancement New feature or enhancement of existing functionality epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented May 1, 2020 •
edited
Loading

Now is when all the hard work setting up the Email service #39 finally pays off!
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies labels May 1, 2020
This was referenced May 1, 2020
Closed
Closed
@nelsonic
Copy link
Member Author

nelsonic commented May 2, 2020

Example of verification email:
image

nelsonic added a commit to dwyl/aws-ses-lambda that referenced this issue May 2, 2020
@nelsonic
create verify.html and verify.txt templates for sending email verific…
892cb16 
…ation for dwyl/auth#62
nelsonic added a commit to dwyl/aws-ses-lambda that referenced this issue May 2, 2020
@nelsonic
pass all lambda event data to template so we can send the verify link…
322f5bb 
… directly from auth app dwyl/auth#62
nelsonic added a commit to dwyl/aws-ses-lambda that referenced this issue May 2, 2020
@nelsonic
add test for verify email dwyl/auth#62
9902013
@nelsonic nelsonic mentioned this issue May 2, 2020
Merged
nelsonic added a commit that referenced this issue May 4, 2020
@nelsonic
[WiP] debugging sending verification email #62 / #63
110f833
@nelsonic
Copy link
Member Author

Verify email is sent with a verification link:
image

The code that generates the verification URL is:

auth/lib/auth_web/controllers/auth_controller.ex

Lines 309 to 314 in fafc5e0

def make_verify_link(conn, person, state) do
AuthPlug.Helpers.get_baseurl_from_conn(conn) <>
"/auth/verify?id=" <>
AuthWeb.ApikeyController.encrypt_encode(person.id) <>
"&referer=" <> state
end

It uses AuthPlug.Helpers.get_baseurl_from_conn/1 which gets the Base URL from conn 😉
(don't you love an obvious sounding helper function?)

Closing as this is working. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or enhancement of existing functionality epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic