Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth_client_id to state in 3rd party auth urls #57

Closed
1 task done
nelsonic opened this issue Apr 29, 2020 · 2 comments
Closed
1 task done

Add auth_client_id to state in 3rd party auth urls #57

nelsonic opened this issue Apr 29, 2020 · 2 comments
Assignees
@nelsonic
Labels
enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Apr 29, 2020 •
edited
Loading

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies labels Apr 29, 2020
@nelsonic nelsonic self-assigned this Apr 29, 2020
nelsonic added a commit that referenced this issue Apr 29, 2020
@nelsonic
add client_id to state sent to 3rd party urls fixes #57
9886ffc
@nelsonic
Copy link
Member Author

Derp! 🤦

image

Need to call it something else ... maybe auth_client_id ?

@nelsonic nelsonic changed the title Add client_id to state in 3rd party auth urls Add auth_client_id to state in 3rd party auth urls Apr 29, 2020
nelsonic added a commit that referenced this issue Apr 29, 2020
@nelsonic
use auth_plug 1.0.0 with auth_client_id url prop #57
0f11599
nelsonic added a commit that referenced this issue Apr 29, 2020
@nelsonic
client_id > auth_client_id #57
333ae6c
nelsonic added a commit that referenced this issue Apr 29, 2020
@nelsonic
client_id > auth_client_id (tests) #57
4257656
nelsonic added a commit that referenced this issue Apr 29, 2020
@nelsonic
client_id > auth_client_id (moar tests) #57
2e60531
nelsonic added a commit that referenced this issue Apr 29, 2020
@nelsonic
add debug statements for #57
6801da1
nelsonic added a commit that referenced this issue Apr 29, 2020
@nelsonic
strip client_id from state before redirecting #57
6a264a4
@nelsonic
Copy link
Member Author

This is working. ✅

nelsonic added a commit to dwyl/auth_plug that referenced this issue Apr 29, 2020
@nelsonic
change name from client_id to auth_client_id in URL for dwyl/auth#57 …
cff36b7 
…(comment)
@nelsonic nelsonic mentioned this issue Apr 29, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic