Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Brunch by Webpack #40

Closed
SimonLab opened this issue Feb 12, 2020 · 3 comments
Closed

Replace Brunch by Webpack #40

SimonLab opened this issue Feb 12, 2020 · 3 comments
Labels
enhancement New feature or enhancement of existing functionality wontfix

Comments

@SimonLab
Copy link
Member

Phoenix is now using Webpack for managing assets instead of Brunch.
We can try to upgrade this by changing the configuration in the asset folder:
https://github.com/dwyl/auth/blob/master/assets/brunch-config.js

@SimonLab SimonLab added the enhancement New feature or enhancement of existing functionality label Feb 12, 2020
@nelsonic
Copy link
Member

@SimonLab switching from Brunch to Webpack is actually quite straightforward:
https://www.phoenixframework.org/blog/upgrading-from-13x-to-140
(scroll down to: "Replace Brunch with webpack" section)

I actually preferred Brunch 🥑
But I can see why the Phoenix team decided to use Webpack ... 📦

However, I think we will be better off "gutting" this project and refreshing with a clean slate. ♻️
We now have elixir-auth-github and elixir-auth-google that implement a lot of functionality. ⭐️
As soon as we have the email Lambda Function aws-ses-lambda working, 💌
we will be able to re-do this quite easily. By that I mean mix phx.new auth ... 🆕
Which will be a lot faster than having to delete/update a bunch of things. ⏩

We want to do a lot more documentation for the auth project while building it,
similar to dwyl/phoenix-chat-example 📝
That way it will be a lot easier for complete beginners to understand & use the auth project. 🌱

Our goal is that people building projects in other programming languages can one-click deploy auth so they can focus on the "core" features of their App and not think about any auth code. 👩‍💻

@SimonLab
Copy link
Member Author

Agree, starting from a fresh Phoenix project will be faster than trying to update/clean the current code.
It's also a good way to review all the requirements for auth (e,g. database structure, google/github auth, email/password, api endpoints)

@nelsonic
Copy link
Member

nelsonic commented Apr 1, 2020

Closing as Brunch will be removed by #43

@nelsonic nelsonic closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement of existing functionality wontfix
Projects
None yet
Development

No branches or pull requests

2 participants