Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the description of a timer after its been stopped? #95

Closed
nelsonic opened this issue Apr 7, 2015 · 8 comments
Closed

Update the description of a timer after its been stopped? #95

nelsonic opened this issue Apr 7, 2015 · 8 comments
Labels
discuss Share your constructive thoughts on how to make progress with this issue help wanted If you can help make progress with this issue, please comment! question A question needs to be answered before progress can be made on this issue
Milestone

Comments

@nelsonic
Copy link
Member

nelsonic commented Apr 7, 2015

Should a person be able to update the description of a timer/activity that has already been completed?
(and is this MVP?)

@nelsonic nelsonic added question A question needs to be answered before progress can be made on this issue help wanted If you can help make progress with this issue, please comment! discuss Share your constructive thoughts on how to make progress with this issue FrontEnd labels Apr 7, 2015
@harrygfox
Copy link
Member

If it helps to say: I do this constantly on Toggl: I think of a better description once I've done it than when I set out. I know that's probably bad practice because clearly the scope of my tasks weren't well defined before I started but I certainly would find it hand to be able to update.

@iteles
Copy link
Member

iteles commented Apr 7, 2015

Absolutely an open question: #31 (comment)

I've actually added this particular question as a post-MVP question: https://github.com/ideaq/time/blob/master/MVP.md#open-questions

@iteles
Copy link
Member

iteles commented Apr 7, 2015

@harrygfox That's SUPER useful to know, thank you!

@nelsonic
Copy link
Member Author

nelsonic commented Apr 9, 2015

Should we display a _form_ with a save button or are we sticking with the _no buttons_ theme you have going on @iteles ?

timer-timing

@iteles
Copy link
Member

iteles commented Apr 9, 2015

On the one hand I feel like it would be intuitive to have it save on blur() like the main timer, but if you have a screen full of timers, you may not be sure where you can safely press without unintentional consequences. I would suggest that the 'tick' icon becomes a SAVE button when a past timer description is clicked onto.

@nelsonic
Copy link
Member Author

nelsonic commented Apr 9, 2015

Done:
edit-timer-description

@nelsonic
Copy link
Member Author

nelsonic commented Apr 9, 2015

@iteles git pull if you want to style it.

@iteles iteles modified the milestone: MVP Apr 9, 2015
@iteles
Copy link
Member

iteles commented Apr 10, 2015

Completed in commit cf9dc6d with functionality fixed in commit 6945f92 and styled in commit c2fe3b6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Share your constructive thoughts on how to make progress with this issue help wanted If you can help make progress with this issue, please comment! question A question needs to be answered before progress can be made on this issue
Projects
None yet
Development

No branches or pull requests

3 participants