From 2f0828e0f5ca3639345205201feeb091b898ea05 Mon Sep 17 00:00:00 2001 From: Alessandro Boron Date: Tue, 16 Apr 2024 16:21:48 +1000 Subject: [PATCH] =?UTF-8?q?Fix=20an=20issue=20where=20the=20origin=20sent?= =?UTF-8?q?=20in=20the=20pixel=20would=20be=20empty=20due=20to=E2=80=A6=20?= =?UTF-8?q?(#2628)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Task/Issue URL: https://app.asana.com/0/1199230911884351/1207084618662354/f **Description**: Fix an issue where the Installation Attribution origin sent with the pixel is empty due to the wrong file referenced to read its value. --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f) --- .github/workflows/create_variant.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/create_variant.yml b/.github/workflows/create_variant.yml index 502080b8e1..682467036d 100644 --- a/.github/workflows/create_variant.yml +++ b/.github/workflows/create_variant.yml @@ -120,7 +120,7 @@ jobs: run: | codesign -d --entitlements :- DuckDuckGo.app > entitlements.plist echo "${{ env.ATB_VARIANT_NAME }}" > "DuckDuckGo.app/Contents/Resources/variant.txt" - echo "${{ env.ORIGIN_VARIANT_NAME }}" > "DuckDuckGo.app/Contents/Resources/origin.txt" + echo "${{ env.ORIGIN_VARIANT_NAME }}" > "DuckDuckGo.app/Contents/Resources/Origin.txt" sign_identity="$(security find-certificate -a -c "Developer ID Application" -Z | grep ^SHA-1 | cut -d " " -f3 | uniq)" /usr/bin/codesign \