From c82e1c898bc881af05e34aec9d22ef082ad374e7 Mon Sep 17 00:00:00 2001 From: Sam Symons Date: Fri, 29 Nov 2024 18:03:18 -0800 Subject: [PATCH] Remove malformed error pixel (#3647) Task/Issue URL: https://app.asana.com/0/414235014887631/1208683003138954/f Tech Design URL: CC: Description: This PR removes the malformed error pixel. --- Core/PixelEvent.swift | 4 ---- DuckDuckGo.xcodeproj/project.pbxproj | 6 +----- .../xcshareddata/swiftpm/Package.resolved | 4 ++-- .../NetworkProtectionPacketTunnelProvider.swift | 4 ---- 4 files changed, 3 insertions(+), 15 deletions(-) diff --git a/Core/PixelEvent.swift b/Core/PixelEvent.swift index d7433366d2..5fc44638c9 100644 --- a/Core/PixelEvent.swift +++ b/Core/PixelEvent.swift @@ -474,8 +474,6 @@ extension Pixel { case networkProtectionConfigurationInvalidPayload(configuration: Configuration) - case networkProtectionMalformedErrorDetected - // MARK: - VPN Tips case networkProtectionGeoswitchingTipShown @@ -1336,8 +1334,6 @@ extension Pixel.Event { case .networkProtectionConfigurationInvalidPayload(let config): return "m_netp_vpn_configuration_\(config.rawValue)_invalid_payload" - case .networkProtectionMalformedErrorDetected: return "m_netp_vpn_malformed_error_detected" - // MARK: VPN tips case .networkProtectionGeoswitchingTipShown: return "m_vpn_tip_geoswitching_shown" diff --git a/DuckDuckGo.xcodeproj/project.pbxproj b/DuckDuckGo.xcodeproj/project.pbxproj index 6ba7046c3e..e0b5d4e5a1 100644 --- a/DuckDuckGo.xcodeproj/project.pbxproj +++ b/DuckDuckGo.xcodeproj/project.pbxproj @@ -2025,7 +2025,6 @@ 983C52E32C2C050B007B5747 /* BookmarksStateRepair.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BookmarksStateRepair.swift; sourceTree = ""; }; 983C52E52C2C0ABA007B5747 /* BookmarkStateRepairTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BookmarkStateRepairTests.swift; sourceTree = ""; }; 983D71B02A286E810072E26D /* SyncDebugViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SyncDebugViewController.swift; sourceTree = ""; }; - 983D88D52CED006000E99B46 /* UnitTests copy-Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; name = "UnitTests copy-Info.plist"; path = "/Users/bartek/Develop/iOS/UnitTests copy-Info.plist"; sourceTree = ""; }; 983E1349251EABF200149BD9 /* fi */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = fi; path = fi.lproj/InfoPlist.strings; sourceTree = ""; }; 983E134A251EABF200149BD9 /* fi */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = fi; path = fi.lproj/InfoPlist.strings; sourceTree = ""; }; 983E134C251EABF200149BD9 /* fi */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = fi; path = fi.lproj/InfoPlist.strings; sourceTree = ""; }; @@ -2040,7 +2039,6 @@ 984147C424F026C800362052 /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/HomeRow.storyboard; sourceTree = ""; }; 984147CA24F02E9E00362052 /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/DaxOnboarding.storyboard; sourceTree = ""; }; 98424AA92CED4F430071C7DB /* WebViewUnitTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = WebViewUnitTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; }; - 98424AAA2CED4F430071C7DB /* UnitTests copy-Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; name = "UnitTests copy-Info.plist"; path = "/Users/bartek/Develop/iOS/UnitTests copy-Info.plist"; sourceTree = ""; }; 9846AA6622BD3BBF007DE48E /* InitHelpers.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = InitHelpers.swift; sourceTree = ""; }; 9847BFFD27A2DDB400DB07AA /* ContentBlocking.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ContentBlocking.swift; sourceTree = ""; }; 9847BFFF27A2DDBB00DB07AA /* AppPrivacyConfigurationDataProvider.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = AppPrivacyConfigurationDataProvider.swift; sourceTree = ""; }; @@ -4257,8 +4255,6 @@ 83ED3B8D1FA8E63700B47556 /* README.md */, 83ED3B8C1FA8E61D00B47556 /* ManualTestsScript.md */, 85A313962028E78A00327D00 /* release_notes.txt */, - 983D88D52CED006000E99B46 /* UnitTests copy-Info.plist */, - 98424AAA2CED4F430071C7DB /* UnitTests copy-Info.plist */, ); sourceTree = ""; }; @@ -11247,7 +11243,7 @@ repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit"; requirement = { kind = exactVersion; - version = 215.0.1; + version = 216.0.0; }; }; 9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = { diff --git a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved index d6698fc14d..0268a2f9d8 100644 --- a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved +++ b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved @@ -32,8 +32,8 @@ "kind" : "remoteSourceControl", "location" : "https://github.com/DuckDuckGo/BrowserServicesKit", "state" : { - "revision" : "837dfbfe7a1b2a5e0ec2fb24a47a53dec53444b0", - "version" : "215.0.1" + "revision" : "1f1a9f979671e886699ef9b5edd572bc6b490875", + "version" : "216.0.0" } }, { diff --git a/PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift b/PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift index 1f485fb540..30c02830ee 100644 --- a/PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift +++ b/PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift @@ -295,10 +295,6 @@ final class NetworkProtectionPacketTunnelProvider: PacketTunnelProvider { vpnLogger.logStartingWithoutAuthToken() DailyPixel.fireDailyAndCount(pixel: .networkProtectionTunnelStartAttemptOnDemandWithoutAccessToken, pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes) - case .malformedErrorDetected(let error): - DailyPixel.fireDailyAndCount(pixel: .networkProtectionMalformedErrorDetected, - pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes, - error: error) } }