diff --git a/Core/Pixel.swift b/Core/Pixel.swift
index 5c24bee78b..229598fd36 100644
--- a/Core/Pixel.swift
+++ b/Core/Pixel.swift
@@ -214,13 +214,14 @@ extension Pixel {
public static func fire(pixel: Pixel.Event,
error: Error?,
+ includedParameters: [QueryParameters] = [.appVersion],
withAdditionalParameters params: [String: String] = [:],
onComplete: @escaping (Error?) -> Void = { _ in }) {
var newParams = params
if let error {
newParams.appendErrorPixelParams(error: error)
}
- fire(pixel: pixel, withAdditionalParameters: newParams, includedParameters: [], onComplete: onComplete)
+ fire(pixel: pixel, withAdditionalParameters: newParams, includedParameters: includedParameters, onComplete: onComplete)
}
}
diff --git a/Core/PixelEvent.swift b/Core/PixelEvent.swift
index 7036fbbe60..0365fca0f8 100644
--- a/Core/PixelEvent.swift
+++ b/Core/PixelEvent.swift
@@ -74,6 +74,19 @@ extension Pixel {
case browsingMenuFireproof
case browsingMenuAutofill
+ case addressBarShare
+ case addressBarSettings
+
+ case shareSheetResultSuccess
+ case shareSheetResultFail
+ case shareSheetActivityCopy
+ case shareSheetActivityAddBookmark
+ case shareSheetActivityAddFavorite
+ case shareSheetActivityFindInPage
+ case shareSheetActivityPrint
+ case shareSheetActivityAddToReadingList
+ case shareSheetActivityOther
+
case tabBarBackPressed
case tabBarForwardPressed
case bookmarksButtonPressed
@@ -570,7 +583,6 @@ extension Pixel.Event {
case .browsingMenuRemoveFromFavorites: return "mb_df"
case .browsingMenuAddToFavoritesAddFavoriteFlow: return "mb_aff"
case .browsingMenuToggleBrowsingMode: return "mb_dm"
- case .browsingMenuShare: return "mb_sh"
case .browsingMenuCopy: return "mb_cp"
case .browsingMenuPrint: return "mb_pr"
case .browsingMenuSettings: return "mb_st"
@@ -580,7 +592,21 @@ extension Pixel.Event {
case .browsingMenuReportBrokenSite: return "mb_rb"
case .browsingMenuFireproof: return "mb_f"
case .browsingMenuAutofill: return "m_nav_autofill_menu_item_pressed"
-
+
+ case .browsingMenuShare: return "m_browsingmenu_share"
+
+ case .addressBarShare: return "m_addressbar_share"
+ case .addressBarSettings: return "m_addressbar_settings"
+ case .shareSheetResultSuccess: return "m_sharesheet_result_success"
+ case .shareSheetResultFail: return "m_sharesheet_result_fail"
+ case .shareSheetActivityCopy: return "m_sharesheet_activity_copy"
+ case .shareSheetActivityAddBookmark: return "m_sharesheet_activity_addbookmark"
+ case .shareSheetActivityAddFavorite: return "m_sharesheet_activity_addfavorite"
+ case .shareSheetActivityFindInPage: return "m_sharesheet_activity_findinpage"
+ case .shareSheetActivityPrint: return "m_sharesheet_activity_print"
+ case .shareSheetActivityAddToReadingList: return "m_sharesheet_activity_addtoreadinglist"
+ case .shareSheetActivityOther: return "m_sharesheet_activity_other"
+
case .tabBarBackPressed: return "mt_bk"
case .tabBarForwardPressed: return "mt_fw"
case .bookmarksButtonPressed: return "mt_bm"
diff --git a/Core/UIViewControllerExtension.swift b/Core/UIViewControllerExtension.swift
index f37bca411b..4e91074719 100644
--- a/Core/UIViewControllerExtension.swift
+++ b/Core/UIViewControllerExtension.swift
@@ -50,11 +50,15 @@ extension UIViewController {
present(controller: shareController, fromButtonItem: buttonItem)
}
- public func presentShareSheet(withItems activityItems: [Any], fromView sourceView: UIView, atPoint point: Point? = nil, completion: UIActivityViewController.CompletionWithItemsHandler? = nil) {
+ public func presentShareSheet(withItems activityItems: [Any], fromView sourceView: UIView, atPoint point: Point? = nil, overrideInterfaceStyle: UIUserInterfaceStyle? = nil, completion: UIActivityViewController.CompletionWithItemsHandler? = nil) {
let activities = buildActivities()
let shareController = UIActivityViewController(activityItems: activityItems, applicationActivities: activities)
shareController.completionWithItemsHandler = completion
- shareController.overrideUserInterfaceStyle()
+ if let overrideInterfaceStyle {
+ shareController.overrideUserInterfaceStyle = overrideInterfaceStyle
+ } else {
+ shareController.overrideUserInterfaceStyle()
+ }
shareController.excludedActivityTypes = [.markupAsPDF]
present(controller: shareController, fromView: sourceView, atPoint: point)
}
diff --git a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
index 3afe4e093f..e8323140fd 100644
--- a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
+++ b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -156,7 +156,7 @@
},
{
"package": "TrackerRadarKit",
- "repositoryURL": "https://github.com/duckduckgo/TrackerRadarKit.git",
+ "repositoryURL": "https://github.com/duckduckgo/TrackerRadarKit",
"state": {
"branch": null,
"revision": "4684440d03304e7638a2c8086895367e90987463",
diff --git a/DuckDuckGo/Base.lproj/Settings.storyboard b/DuckDuckGo/Base.lproj/Settings.storyboard
index 1d4eb7fa61..63439e5402 100644
--- a/DuckDuckGo/Base.lproj/Settings.storyboard
+++ b/DuckDuckGo/Base.lproj/Settings.storyboard
@@ -104,7 +104,7 @@
-