Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing entities without records in feature table #69

Closed
shaycrk opened this issue May 13, 2017 · 1 comment
Closed

missing entities without records in feature table #69

shaycrk opened this issue May 13, 2017 · 1 comment
Labels
bug

Comments

@shaycrk
Copy link
Contributor

shaycrk commented May 13, 2017 •
edited
Loading

Running a set of leave-one-in models, I'm getting different numbers of entities with predictions and even different numbers of labeled examples in the test set depending on which feature set is being included. It seems to be the case that entities without any record in the included feature table are being excluded entirely, even if they have labels in the test set.
@shaycrk shaycrk added the bug label May 13, 2017
ecsalomon added a commit that referenced this issue May 15, 2017
@ecsalomon
Select Entities from Entities Table:
21fadcf 
If merged, this commit will:

- change the logic for creating entity-date sets so that for train sets, it filters the labels against and entities table and for test sets, it creates a cross join of all entities in the entities table and the dates for the matrix [Resolves #69]
- creates entity date tables as temporary tables [Resolves #60], [Resolves #51]
- reformats entity date table names so that uuid is last [Resolves #50]
@ecsalomon ecsalomon mentioned this issue May 15, 2017
Closed
@thcrock thcrock mentioned this issue Jul 25, 2017
Closed
@thcrock
Copy link
Collaborator

thcrock commented Jul 25, 2017

Now in: dssg/architect#28

@thcrock thcrock closed this as completed Jul 25, 2017
@jesteria jesteria mentioned this issue Dec 12, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shaycrk @thcrock