Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in FAQ crashes #38

Open
Chinmay-KB opened this issue Sep 29, 2019 · 3 comments
Open

Search in FAQ crashes #38

Chinmay-KB opened this issue Sep 29, 2019 · 3 comments
Labels
hacktoberfest For Hacktoberfest hacktoberfest2020 For Hacktoberfest 2020 hacktoberfest-nitr For Hacktoberfest NIT Rourkela intermediate One needs to be a bit more familiar with the workings of Flutter to solve these issues type: bug Something isn't working

Comments

@Chinmay-KB
Copy link
Member

If for some reason the internet is down while we are searching something in FAQ, app crashes instantly

Steps to reproduce the behaviour:

  1. Go to FAQ
  2. Let the initial list load
  3. Turn off your Mobile data/WiFi
  4. Try searching for something

If we are already into the FAQ section and then net connection is down, then we just exit the FAQ screen. If net is down in the homepage itself, i.e before tapping onto the FAQ card, the whole app crashes and exits

  • Device: Moto G5+
  • OS: PixelOS(Android 9.0 flavour)

Thing to consider here is that FAQ section has been implemented in Native and integrated into Flutter using Platform channel. Checking for internet availability before sending any request should squash the bug

@Chinmay-KB Chinmay-KB added type: bug Something isn't working good first issue Good for newcomers hacktoberfest For Hacktoberfest hacktoberfest-nitr For Hacktoberfest NIT Rourkela intermediate One needs to be a bit more familiar with the workings of Flutter to solve these issues labels Sep 29, 2019
@ferquies
Copy link

ferquies commented Oct 3, 2019

I take care of it! 👍

ferquies added a commit to ferquies/project-avocado that referenced this issue Oct 3, 2019
Add a function to check the internet availability and use it before make any network calls
ferquies added a commit to ferquies/project-avocado that referenced this issue Oct 3, 2019
Add a function to check the internet availability and use it before make any network calls
@Chinmay-KB
Copy link
Member Author

Okay, so there are a few places where we need an active internet connection

  1. FAQ
  2. Book your appointment
  3. Mentors

It would be nice if you could check for internet connection everywhere.
Also, display an appropriate snackbar notifying the user of the inactive internet connection.

I'd recommend you to rather implement the internet connectivity logic on the flutter side than in native, so that implementing the snackbar is easier for you

@ferquies
Copy link

ferquies commented Oct 5, 2019

Ok, in Mentors section there are actually a button that indicates there is no internet connection. Did you mean we must show the "No internet connection" snackbar before open any section that needs internet or implement the snackbar inside each section?
And in case we must show the snackbar inside each screen, in the case of FAQ I have to show it in native.

@DesignrKnight DesignrKnight removed hacktoberfest For Hacktoberfest hacktoberfest-nitr For Hacktoberfest NIT Rourkela good first issue Good for newcomers labels Jul 16, 2020
@DesignrKnight DesignrKnight added hacktoberfest For Hacktoberfest hacktoberfest-nitr For Hacktoberfest NIT Rourkela hacktoberfest2020 For Hacktoberfest 2020 labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest For Hacktoberfest hacktoberfest2020 For Hacktoberfest 2020 hacktoberfest-nitr For Hacktoberfest NIT Rourkela intermediate One needs to be a bit more familiar with the workings of Flutter to solve these issues type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants