-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search in FAQ crashes #38
Comments
I take care of it! 👍 |
Add a function to check the internet availability and use it before make any network calls
Add a function to check the internet availability and use it before make any network calls
Okay, so there are a few places where we need an active internet connection
It would be nice if you could check for internet connection everywhere. I'd recommend you to rather implement the internet connectivity logic on the flutter side than in native, so that implementing the snackbar is easier for you |
Ok, in Mentors section there are actually a button that indicates there is no internet connection. Did you mean we must show the "No internet connection" snackbar before open any section that needs internet or implement the snackbar inside each section? |
If for some reason the internet is down while we are searching something in FAQ, app crashes instantly
Steps to reproduce the behaviour:
If we are already into the FAQ section and then net connection is down, then we just exit the FAQ screen. If net is down in the homepage itself, i.e before tapping onto the FAQ card, the whole app crashes and exits
Thing to consider here is that FAQ section has been implemented in Native and integrated into Flutter using Platform channel. Checking for internet availability before sending any request should squash the bug
The text was updated successfully, but these errors were encountered: