Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User authentication #6

Open
jbinvnt opened this issue Apr 8, 2020 · 2 comments · May be fixed by #24
Open

User authentication #6

jbinvnt opened this issue Apr 8, 2020 · 2 comments · May be fixed by #24
Assignees
Labels
enhancement New feature or request

Comments

@jbinvnt
Copy link
Member

jbinvnt commented Apr 8, 2020

We should be able to designate API requests as requiring authentication. This could be either a single API key or a username/password pair. Users must then send their credentials with requests that require it.

cURL has the -u flag and axios can set the auth property in its configuration.

@abhinavtripathy
Copy link
Member

@jbinvnt I was wondering whether it would be a good idea to integrate firebase auth with this project: https://firebase.google.com/docs/auth. This would allow OAuth login methods such as login with facebook/github, github in particular might be useful for us to store in the database.

@jbinvnt
Copy link
Member Author

jbinvnt commented Apr 11, 2020

@abhinavtripathy That's definitely an option we can consider. I've used Firebase's authentication system before and to me it's intuitive. I also haven't learned yet about the traditional method of adding OAuth to a website. However a downside of Firebase is that then our users would need to create their own project in the Firebase Console in order to use something like GitHub login.

@jbinvnt jbinvnt added the enhancement New feature or request label Jul 19, 2020
@jbinvnt jbinvnt linked a pull request Aug 3, 2020 that will close this issue
@DamiAdesola DamiAdesola linked a pull request Aug 4, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants