Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MessengerCommands the default w/ an option #4063

Closed
chx opened this issue May 7, 2019 · 4 comments
Closed

Make MessengerCommands the default w/ an option #4063

chx opened this issue May 7, 2019 · 4 comments

Comments

@chx
Copy link
Contributor

chx commented May 7, 2019

#3489 is awesome. There are no articles, examples or tests so I'd wager noone knows its there. It's not easy to find. Why not move the functionality to DrushCommands triggered with an option? If I had any idea on how to take options in MessengerCommands::log() (or pre/post) I'd write it myself. Ie. if you like the idea and tell me how, I will code this.

@weitzman
Copy link
Member

weitzman commented May 7, 2019

It's a commandfile so it loads on every request. You don't need to extend it - it logs all Drupal messages to the drush log. The disclaimer is that it only works after Drupal has fully bootstrapped. So it misses messages during cache rebuild and site install too.

@weitzman weitzman closed this as completed May 7, 2019
@chx
Copy link
Contributor Author

chx commented May 7, 2019

I really don't understand anything Drush does these days. Where could I read more?

@weitzman
Copy link
Member

weitzman commented May 7, 2019

This commandfile is implementing hooks provided by Annotated Command project. See https://github.com/consolidation/annotated-command/blob/master/README.md. I'm also happy to discuss via chat or voice.

@chx
Copy link
Contributor Author

chx commented May 8, 2019

Well then let's continue in consolidation/annotated-command#187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants