Const-ify the descriptor on Message #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goffrie
approved these changes
Dec 10, 2021
cyang1
force-pushed
the
const-descriptor
branch
from
c3f9c77
to
95808a4
Compare
|
Got back around to updating this. I think because the clippy CI command is cd-ing into the |
cyang1
force-pushed
the
const-descriptor
branch
from
95808a4
to
0101e26
Compare
goffrie
reviewed
Dec 18, 2021
| @@ -1012,7 +1012,9 @@ def gen_msg( | |||
| with block(self, "impl ::pb_jelly::Message for " + name): | |||
| with block( | |||
| self, | |||
| "fn descriptor(&self) -> ::std::option::Option<::pb_jelly::MessageDescriptor>", | |||
| "const DESCRIPTOR: ::std::option::Option<::pb_jelly::MessageDescriptor> = ", | |||
| start=" (", | |||
There was a problem hiding this comment.
this causes a double space :p
though is there any point to having the parens at all?
|
Cary Yang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use the descriptor from a const context.